Implement wasmer init and wasmer publish #3324

fschutt · 2022-11-18T12:54:52Z

No description provided.

lib/cli/src/commands/init.rs

Michael-F-Bryan

I think we've got the core of wasmer init here. Let's merge it once CI passes and make a follow-up PR refactoring Init::execute().

fschutt · 2022-12-16T11:24:41Z

@Michael-F-Bryan okay, this should be done now, I removed support for cargo wapm, so those problems with namespace = ... are gone now.

lib/cli/Cargo.toml

lib/cli/src/commands/init.rs

rust-toolchain

fschutt · 2022-12-16T20:52:32Z

bors r+

bors · 2022-12-16T20:52:36Z

👎 Rejected by code reviews

Stale review

fschutt · 2022-12-16T20:53:03Z

bors r+

bors · 2022-12-16T21:02:42Z

Build succeeded:

Code lint

lib/cli/src/commands/publish.rs

Makefile

lib/cli/src/commands/init.rs

syrusakbary · 2022-12-16T22:32:40Z

lib/cli/src/commands/init.rs

+        let toml_string = toml::to_string_pretty(&toml)?
+            .replace(
+                "[dependencies]",
+                &format!("{NOTE}{NEWLINE}{NEWLINE}[dependencies]"),


fschutt requested a review from syrusakbary as a code owner November 18, 2022 12:54

fschutt changed the title ~~Add wasmer init~~ Implement wasmer init Nov 18, 2022

Michael-F-Bryan suggested changes Nov 21, 2022

View reviewed changes

lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved

lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved

lib/cli/src/commands/init.rs Outdated Show resolved Hide resolved

Michael-F-Bryan approved these changes Nov 24, 2022

View reviewed changes

ptitSeb added this to the v3.1 milestone Nov 30, 2022

fschutt mentioned this pull request Dec 2, 2022

Implement wasmer publish #3325

Closed

fschutt modified the milestones: v3.1, v3.2 Dec 6, 2022

fschutt changed the title ~~Implement wasmer init~~ Implement wasmer init and wasmer publish Dec 12, 2022

fschutt added 21 commits December 12, 2022 14:33

Add wasmer init

0dfa9a8

Fix wapm.toml definition

41a311d

Detect cargo wapm and add metadata to Cargo.toml, if applicable

e2126b5

Fix make lint

248b2f2

Fix wapm init compilation

73c6387

wasmer init: migrate to cargo_metadata

a29cc7d

Correctly recognize .wai bindings

507b4f1

cargo fmt

bb3de1f

cargo update

83a4334

Update wapm toml version

e69ea73

Update wapm-toml version again

53a08b4

Refactor wasmer init with comments

c4e1422

Fix make lint

7ba13bc

Add integration tests for wasmer init

b8d1d4e

Fix second integration test for wasmer init

1c754a0

Fix relative path in source of module

ac9d392

Add flow test for wasmer init + cargo wapm publish

2b09fc4

Use current logged in user as namespace in wasmer init

c325ce6

Add debugging to integration test

3eaa585

Update wapm version in Makefile

6ac97af

Install wapm before running integration tests

9a4d21b

fschutt and others added 2 commits December 16, 2022 12:07

Merge branch 'master' into init

5d3b0d4

Fix make lint

d1093ca

ptitSeb reviewed Dec 16, 2022

View reviewed changes

lib/cli/Cargo.toml Outdated Show resolved Hide resolved

ptitSeb reviewed Dec 16, 2022

View reviewed changes

lib/cli/src/commands/init.rs Show resolved Hide resolved

ptitSeb reviewed Dec 16, 2022

View reviewed changes

rust-toolchain Outdated Show resolved Hide resolved

ptitSeb approved these changes Dec 16, 2022

View reviewed changes

fschutt added 2 commits December 16, 2022 18:50

Fix wasmer-wasm-interface version

a4a997c

Revert rust-toolchain changes

00aab24

fschutt force-pushed the init branch from 5abd6f4 to 00aab24 Compare December 16, 2022 17:52

Re-add wasm32-wasi for integration tests

5f01e9d

bors bot merged commit 7a90abf into master Dec 16, 2022

bors bot deleted the init branch December 16, 2022 21:02